Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft reader/codec factory draft - WIP. #50

Closed
wants to merge 7 commits into from
Closed

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Mar 4, 2019

This isn't ready for line-by-line review; more just for discussion at the next meeting.

Draft implementation of a dynamic HtsjdkCodec discovery and registration service, implemented via a java.util.ServiceLoader. Each HtsjdkCodec consists of two classes; a lightweight, dynamically discovered singleton HtsjdkCodecDescriptor, which is cached in a registry, and the actual HtsjdkCodec itself, which is only instantiated with actual inputs when the corresponding HtsjdkCodecDescriptor claims to be able to handle a given input resource.

This PR contains a single stub/mock BAMCodec implementation as a test case for exercising the discovery/registry code.

This does not include any changes discussed during the last meeting(s). In particular:

  • we still need to define an additional service layer for use by codecs to map/resolve input resources to actual consumable channel/stream/resources
  • a way to provide sibling file indetifiers directly

@cmnbroad cmnbroad closed this Mar 4, 2019
@cmnbroad cmnbroad deleted the cn_reader_factory branch March 4, 2019 15:41
@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Mar 4, 2019

Replaced by #51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants