Feat/populate criteria #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enola-dkfz
requested review from
torbrenner,
PierreDelpy,
Threated,
lablans and
TKussel
Threated
approved these changes
Nov 22, 2024
src/catalogue.rs
Outdated
Comment on lines
118
to
125
| let group_key = if group_key == "patient" || group_key == "donor" { | ||
| "patients" | ||
| } else if group_key == "tumor_classification" { | ||
| "diagnosis" | ||
| } else if group_key == "biosamples" { | ||
| } else if group_key == "biosamples" || group_key == "sample" { | ||
| "specimen" | ||
| } else { | ||
| &group_key |
There was a problem hiding this comment.
This would look much nicer with a match
| counts | ||
| .get(key1) | ||
| .and_then(|group| group.get(key2)) | ||
| counts.get(key1).and_then(|group| group.get(key2)) |
There was a problem hiding this comment.
I like and_then but when you return an Option you can also use ? and just chain the operations which is a bit nicer. If you decide to change it also do it for the get_element function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.