Fix Response Status Code for Failing JSON Emits #2218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update both the request body and status in case of errors, not just the body.
allentiak
force-pushed
the
fix-failing-json-emit
branch
2 times, most recently
from
d4c65cf
to
03eceb4
Compare
allentiak
force-pushed
the
fix-failing-json-emit
branch
from
03eceb4
to
aefbc08
Compare
Update both the request body and status in case of errors, not just the body.
allentiak
force-pushed
the
fix-failing-json-emit
branch
from
aefbc08
to
dfd3b10
Compare
allentiak
commented
Nov 26, 2024
allentiak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.