github_prs

Submitting Pull Requests

Please make branch names brief-description and include a full description of what the fixes and features are included.

When performing pull requests, a couple of things will happen:

1. CircleCI will run the make ci target against your branch. This will cause the tox tests to be run and a coverage report to be generated for that test run. When the build is finished, the results of those tests will be uploaded to CircleCI's servers for reference.
2. Danger will be run and a Github user named pyconfig-bot will post a message to your pull request. This will contain a link to the test coverage report generated by the CircleCI build, as well as any additional warnings or errors found with your changes.

It is expected that you will always have a passing build and no issues from Danger to ensure a PR is merged. If these requirements cannot be satisfied as part of your changeset, it is up to the discretion of the project maintainers if they want to merge the changes or not.