Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve node management #1153

Closed
wants to merge 6 commits into from

Conversation

ryoppippi
Copy link
Contributor

  • manage pnpm version by pnpm
  • manage node version by ci
  • install node & pnpm using pnpm itself in ci env

Copy link

socket-security bot commented Dec 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@emotion/[email protected] environment Transitive: filesystem, unsafe +61 10.7 MB emotion-release-bot
npm/@emotion/[email protected] environment Transitive: filesystem, unsafe +56 10.2 MB emotion-release-bot
npm/@fastify/[email protected] None +3 269 kB climba03003
npm/@mui/[email protected] None +2 18.9 MB brijeshb42
npm/@mui/[email protected] environment +22 18.8 MB brijeshb42
npm/@mui/[email protected] environment +20 6.15 MB brijeshb42
npm/@nestia/[email protected] network Transitive: environment, eval, filesystem, shell, unsafe +132 41.3 MB samchon
npm/@nestjs/[email protected] None +2 3.08 MB nestjscore
npm/@trivago/[email protected] Transitive: environment +8 1.88 MB behraang
npm/@types/[email protected] None 0 3.56 MB types
npm/@types/[email protected] None +3 1.44 MB types
npm/[email protected] filesystem, shell Transitive: environment +40 1.55 MB tschaub
npm/[email protected] Transitive: environment +12 1.79 MB stuk
npm/[email protected] Transitive: environment, filesystem +21 923 kB iamvishnusankar
npm/[email protected] environment, filesystem, network, shell, unsafe +23 1.2 GB vercel-release-bot
npm/[email protected] Transitive: environment, eval +24 6.12 MB quietshu
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +424 251 MB quietshu
npm/[email protected] environment +3 4.62 MB gnoff
npm/[email protected] environment +2 337 kB gnoff
npm/[email protected] Transitive: environment, filesystem +15 14.9 MB typedoc-bot

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@vitejs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nestia needs matrix strategy of NodeJS versions. Others are good to see.

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ignoring pnpm-lock.yaml file is inteded.

As this is a library repository, I've always test the ^ version setup startegy.

@ryoppippi ryoppippi closed this Dec 13, 2024
@ryoppippi ryoppippi reopened this Dec 13, 2024
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Possible typosquat attack npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@ryoppippi
Copy link
Contributor Author

ryoppippi commented Dec 13, 2024

I think including lockfile in Node project is fine, because the library version is updated by renovate every time.
Actaully, many major node library repository includes lockfiles like

We need lockfile because of development.

@ryoppippi
Copy link
Contributor Author

I'll add matrix later

@ryoppippi
Copy link
Contributor Author

So managing node version by pnpm is not good for this case?

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As nestia utilizes many NodeJS built-in functions, I think NodeJS version matrix is valid for this repo.

Also, do not change too much style please. Ignoring pnpm-lock.yaml file is required for dependencies' patch and minor updates.

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your endless contribution.

There may be a better and more superior solution, or I may have made a wrong choice.

However, the changes must be made at a level that I can keep going the development.

pnpm-lock.yaml Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be removed with below commented reason.

.gitignore Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change please

- name: Build
working-directory: website
run: npm install && npm run build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, website must use npm at now.

This may be caused by my unskilled monorepo composition, anyway, if try to use pnpm install command in the website directory, it does not install of website, but of other modules enrolled in the pnpm-workspace.yaml file.

By the way, if add the website directory to the pnpm-workspace.yaml file is impossible. It is because the website module requires other module's complete compilation and testing.

@ryoppippi
Copy link
Contributor Author

I'll create another PR based on this!

@ryoppippi ryoppippi closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants