-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed-breaking-changes #53
Open
yeasin50
wants to merge
15
commits into
samarthagarwal:master
Choose a base branch
from
yeasin50:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeasin50
commented
Apr 4, 2023
•
edited
Loading
edited
- fixed button breaking changes
- Compatible & upgrade to flutter 3.7.9
- added device so that it can run and test
- home to navigate between different pages
- fixed-others runtime error
- Skipped rating while it has good package to handle
- slide_list_view
- Missing main asset images
Upgrade to flutter v3
Hi. Thank you for your PR. Are you done with this PR or are you still planning a few more commits to close any open items? |
I am missing assets files, so can't move ahead with current state. I think you can close it. A better case will be adding assets and testing the rest of those item. |
Mhmd-SHA
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.