upgrade cdk and default encryption for compliance #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-goodwin
commented
Oct 21, 2023
Comment on lines
+145
to
+150
| if (this.props.compliancePolicy.isCustomerManagedKeys()) { | ||
| // data in the buckets are encrypted with a key that the customer owns | ||
| this.props.compliancePolicy.dataEncryptionKey.grantEncryptDecrypt( | ||
| grantee | ||
| ); | ||
| } |
There was a problem hiding this comment.
Not sure if I need to do this for AWS-managed keys. I don't have to for AWS-owned because there's zero visibility into that, but AWS-managed creates a key with an alias, like aws/s3 and I'm hoping I don't need to grant permissions but I may.
thantos
reviewed
Oct 21, 2023
|
|
|
Bug: the Entity Tables are using an AWS-owned key instead of an AWS-managed key: 
Fixed in: d16b66b |
sam-goodwin
commented
Oct 23, 2023
thantos
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComplianceConstruct that manages compliance policies and centralizes encryption keys