fix: local entity index query failed when index was missing from local data #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thantos
changed the title
|
Should local compute the indexes instead of persisting |
|
Yeah, I added a TODO to do that, just wanted to fix the breaking issue in this change. Added a TODO and issue #464. |
|
What's left to do here? Fix tests? |
sam-goodwin
approved these changes
Oct 16, 2023
|
Uhh, yeah, the tests randomly fail, don't think it is the fault of this change. Will keep an eye on it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the .eventual/local folder was missing an index (new/deleted),
index.querywould fail on query. change the logic to create requested indices on demand if they were not originally loaded.TODO: Compute missing local indices on load for existing data #464