Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace sleep with time and duration #221

Merged
merged 17 commits into from
Jan 15, 2023
Merged

feat: replace sleep with time and duration #221

merged 17 commits into from
Jan 15, 2023

Conversation

thantos
Copy link
Contributor

@thantos thantos commented Jan 11, 2023 •
edited
Loading

Closes #130

  • Replace sleepFor and sleepUntil calls with time and duration
  • Replace sleepFor and sleepUntil internals with AwaitTime and AwaitDuration
  • Support units in duration (duration(10, "seconds"))
  • Support time, duration, and condition in the timeout fields.
  • remove condition command

sam-goodwin
sam-goodwin requested changes Jan 13, 2023
View reviewed changes
Copy link
Owner

@sam-goodwin sam-goodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all the deleted code.

Prepare a pr for the updates docs too

packages/@eventual/core/src/await-time.ts Outdated Show resolved Hide resolved
packages/@eventual/core/src/runtime/handlers/activity-worker.ts Show resolved Hide resolved
packages/@eventual/core/src/util.ts Outdated Show resolved Hide resolved
packages/@eventual/core/test/commend-executor.test.ts Show resolved Hide resolved
@thantos thantos marked this pull request as ready for review January 13, 2023 18:57
@thantos thantos requested a review from sam-goodwin January 13, 2023 22:37
@thantos
Copy link
Contributor Author

thantos commented Jan 13, 2023

Love all the deleted code.

Prepare a pr for the updates docs too

functionless/eventual-website#5

@sam-goodwin sam-goodwin merged commit 27fc1fa into main Jan 15, 2023
@sam-goodwin sam-goodwin deleted the sussman/await_time branch January 15, 2023 09:36
@sam-goodwin sam-goodwin mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-goodwin sam-goodwin sam-goodwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ergonomics of timeoutSeconds is rough
2 participants
@thantos @sam-goodwin