Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Improve description #68

Merged
merged 2 commits into from
Jun 18, 2024
Merged

README: Improve description #68

merged 2 commits into from
Jun 18, 2024

Conversation

Fede2782
Copy link
Contributor

Samsung Cloud Enhanced Data security is only available on Samsung One UI 5.1.1 and later which have Knox Matrix support. One UI 5.1 doesn't have this feature.

Private Share is now integrated in Quick Share and the fix has already been included since #57 for One UI 5.1.1 and later. This change also apply for previous One UI versions but here you only need to pass Play integrity.

Fede2782 added 2 commits June 18, 2024 15:45
Samsung Cloud Enhanced Data security is only available on Samsung One UI 5.1.1 and later which have Knox Matrix support. One UI 5.1 doesn't have this feature. 

Private Share is now integrated in Quick Share and the fix has already been included since #57 for One UI 5.1.1 and later. This change also apply for previous One UI versions but here you only need to pass Play integrity.
@salvogiangri
Copy link
Owner

Is Play Integrity attestation actually used in Quick Share? Iirc the PIF note was there as SCPM app falls back to that if KmxService is not supported.

@salvogiangri salvogiangri self-requested a review June 18, 2024 13:56
@Fede2782
Copy link
Contributor Author

Fede2782 commented Jun 18, 2024

Is Play Integrity attestation actually used in Quick Share? Iirc the PIF note was there as SCPM app falls back to that if KmxService is not supported.

I remember you told me that Quick Share uses PIF instead of SAK on pre-5.1.1 devices when i initially reported the issue. You wrote also this on a previous KnoxPatch changelog

"As reported by @Fede2782, Samsung has recently merged the Private Share feature inside their Quick Share app. Devices running One UI 5.1 or lower might need to install USNF or similar to get the feature to work."

@salvogiangri
Copy link
Owner

I'm a bit rusty about this but I'm gonna merge this as Enhanced data protection isn't shown in the Settings when the KmxService app is not installed.

@salvogiangri salvogiangri merged commit 67d1f8e into salvogiangri:main Jun 18, 2024
1 check passed
@Fede2782
Copy link
Contributor Author

I made this change mainly to make users know that Enhanced Data Protection is not available on One UI 5.1 and is shown only on One UI 5.1.1 and later.

@Fede2782 Fede2782 deleted the readme-fix branch June 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants