Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: add Samsung China Activation support #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

salvogiangri
Copy link
Owner

@salvogiangri salvogiangri commented Sep 12, 2023

@salvogiangri
Copy link
Owner Author

salvogiangri commented Sep 12, 2023

@mio-19 @gopise mind if you give a try to this? Will implement in the next release if you confirm this fixes the issue in your end.

https://github.com/BlackMesa123/KnoxPatch/actions/runs/6160659642

@mio-19
Copy link

mio-19 commented Sep 16, 2023

I decided to use the Hong Kong firmware and don't have Samsung device for testing for now.

@gopise Would it be possible for you to test this patch if you happen to have an available Samsung phone?

@gopise
Copy link

gopise commented Sep 19, 2023

@blackmesa123 I'm now using a custom ROM (Aurora) which have Magisk pre-integrated and doesn't have this issue.
Are you going to implement it into KnoxPatch (not Magisk)? How should i test? It will be blocked right after flash the cooked boot image. Flash it in TWRP?

@salvogiangri
Copy link
Owner Author

Are you going to implement it into KnoxPatch (not Magisk)?

If the fix works it not something that can be implemented in Magisk unfortunately. SAK generation will not work when the device's ICD status is broken (custom binaries installed), so the only way is by using KnoxPatch or a custom ROM with the SAK fix implemented.

How should i test? It will be blocked right after flash the cooked boot image. Flash it in TWRP?

Install KnoxPatch+LSPosed, make sure you select all the recommended apps, reboot and see if the activation works. The fix is implemented in the module (app) not in the Enhancer, so there's nothing to flash via recovery nor Magisk/KSU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants