New Flight Model #434

boufogre · 2022-04-17T09:43:45Z

New Flight Model

DesertRick13 · 2022-04-18T00:50:32Z

Now this is where things begin to get really interesting! I look forward to good things.

into pr/434

helbertgs · 2023-01-11T12:47:07Z

salty-747/html_ui/Pages/Salty/SaltyFADEC.js

+    update() {
+        //t += 0.001;
+        for (let i = 1; i < 5; i++){
+            let index = i;
+            RegisterViewListener("JS_LISTENER_KEYEVENT");
+            this.keyListener = RegisterViewListener('JS_LISTENER_KEYEVENT', () => {
+                Coherent.call('INTERCEPT_KEY_EVENT', 'INCREASE_THROTTLE', 0);
+                Coherent.call('INTERCEPT_KEY_EVENT', 'DECREASE_THROTTLE', 0);
+                Coherent.call('INTERCEPT_KEY_EVENT', 'THROTTLE_CUT', 0);
+                //Coherent.call('INTERCEPT_KEY_EVENT', '')
+                /*this.keyListener.on('keyIntercepted', keyEventName => {
+                    if (keyEventName === 'THROTTLE_CUT')  {
+                        console.log('THROTTLE CUT INTERCEPTED');
+                        SimVar.SetSimVarValue("K:AXIS_THROTTLE_SET", "position 16K", 5995);
+                    }
+                });*/
+
+            });
+            //this.getEAI(index);
+            //this.getBleed(index);
+            //this.getAlternate(index);
+            //this.getTLA(index);
+            //this.getIdleN1(index);
+            //this.getMaxN1(index);
+            this.setCommandedN1(index);
+            this.setCommandedN2(index);
+            this.setCommandedFF(index);
+            //this.setN2(index);
+            //this.setN1(index);
+            //this.setFuelFlow(index);
+        }
+    return;
+    }


Suggested change

update() {

//t += 0.001;

for (let i = 1; i < 5; i++){

let index = i;

RegisterViewListener("JS_LISTENER_KEYEVENT");

this.keyListener = RegisterViewListener('JS_LISTENER_KEYEVENT', () => {

Coherent.call('INTERCEPT_KEY_EVENT', 'INCREASE_THROTTLE', 0);

Coherent.call('INTERCEPT_KEY_EVENT', 'DECREASE_THROTTLE', 0);

Coherent.call('INTERCEPT_KEY_EVENT', 'THROTTLE_CUT', 0);

//Coherent.call('INTERCEPT_KEY_EVENT', '')

/*this.keyListener.on('keyIntercepted', keyEventName => {

if (keyEventName === 'THROTTLE_CUT') {

console.log('THROTTLE CUT INTERCEPTED');

SimVar.SetSimVarValue("K:AXIS_THROTTLE_SET", "position 16K", 5995);

}

});*/

});

//this.getEAI(index);

//this.getBleed(index);

//this.getAlternate(index);

//this.getTLA(index);

//this.getIdleN1(index);

//this.getMaxN1(index);

this.setCommandedN1(index);

this.setCommandedN2(index);

this.setCommandedFF(index);

//this.setN2(index);

//this.setN1(index);

//this.setFuelFlow(index);

}

return;

}

update() {

for (let i = 1; i < 5; i++){

let index = i;

RegisterViewListener("JS_LISTENER_KEYEVENT");

this.keyListener = RegisterViewListener('JS_LISTENER_KEYEVENT', () => {

Coherent.call('INTERCEPT_KEY_EVENT', 'INCREASE_THROTTLE', 0);

Coherent.call('INTERCEPT_KEY_EVENT', 'DECREASE_THROTTLE', 0);

Coherent.call('INTERCEPT_KEY_EVENT', 'THROTTLE_CUT', 0);

});

}

return;

}

helbertgs · 2023-01-11T12:48:14Z

salty-747/html_ui/Pages/Salty/SaltyFADEC.js

+    getIdleN1(index){
+        //let flaps = this.getFlaps();
+        let eai = this.getEAI(index);
+        //let reverser = this.getReverser(index);
+        let idleN1 = 20.2;
+        if (eai /*|| flaps >= 20 || reverser*/) {
+            idleN1 += 14.1;
+        }
+        SimVar.SetSimVarValue(`L:SALTY_EEC_IDLE_N1:${index}`, "percent", idleN1);
+        return idleN1;
+    }


Suggested change

getIdleN1(index){

//let flaps = this.getFlaps();

let eai = this.getEAI(index);

//let reverser = this.getReverser(index);

let idleN1 = 20.2;

if (eai /*|| flaps >= 20 || reverser*/) {

idleN1 += 14.1;

}

SimVar.SetSimVarValue(`L:SALTY_EEC_IDLE_N1:${index}`, "percent", idleN1);

return idleN1;

}

getIdleN1(index){

let eai = this.getEAI(index);

let idleN1 = 20.2;

if (eai) {

idleN1 += 14.1;

}

SimVar.SetSimVarValue(`L:SALTY_EEC_IDLE_N1:${index}`, "percent", idleN1);

return idleN1;

}

helbertgs · 2023-01-11T12:49:11Z

salty-747/html_ui/Pages/Salty/SaltyFADEC.js

+    getMaxN1(index) {
+        //let eai = this.getEAI(index);
+        let bleed = this.getBleed(index);
+        let alternate = this.getAlternate(index);
+        let maxN1 = 98.5;
+        if (bleed) {
+            maxN1 -= 0.6; 
+        }
+        if (alternate) {
+            maxN1 = 106.7;
+        }
+        //SimVar.SetGameVarValue(`ENG MAX N1${index}`, "percent", maxN1);
+        //let test = SimVar.GetGameVarValue(`ENG MAX N1${index}`, "percent");
+        SimVar.SetSimVarValue("L:SALTY_EEC_MAX_N1", "percent", maxN1);
+        //console.log(test);
+        return maxN1;
+    }


Suggested change

getMaxN1(index) {

//let eai = this.getEAI(index);

let bleed = this.getBleed(index);

let alternate = this.getAlternate(index);

let maxN1 = 98.5;

if (bleed) {

maxN1 -= 0.6;

}

if (alternate) {

maxN1 = 106.7;

}

//SimVar.SetGameVarValue(`ENG MAX N1${index}`, "percent", maxN1);

//let test = SimVar.GetGameVarValue(`ENG MAX N1${index}`, "percent");

SimVar.SetSimVarValue("L:SALTY_EEC_MAX_N1", "percent", maxN1);

//console.log(test);

return maxN1;

}

getMaxN1(index) {

let bleed = this.getBleed(index);

let alternate = this.getAlternate(index);

let maxN1 = 98.5;

if (bleed) {

maxN1 -= 0.6;

}

if (alternate) {

maxN1 = 106.7;

}

SimVar.SetSimVarValue("L:SALTY_EEC_MAX_N1", "percent", maxN1);

return maxN1;

}

helbertgs · 2023-01-11T12:49:41Z

salty-747/html_ui/Pages/Salty/SaltyFADEC.js

+    setCommandedN1(index) {
+        //let alt = SimVar.GetSimVarValue("PRESSURE ALTITUDE", "feet");
+        let tat = SimVar.GetSimVarValue("TOTAL AIR TEMPERATURE", "kelvin");
+        let theta2 = tat / 288.15;
+        let tla = this.getTLA(index);
+        let idleN1 = this.getIdleN1(index);
+        let maxN1 = this.getMaxN1(index);
+        let comN1 = 0.01 * (maxN1 - idleN1) * tla + idleN1;
+        SimVar.SetSimVarValue(`L:SALTY_EEC_COM_N1:${index}`, "number", comN1);
+        //SimVar.SetSimVarValue(`TURB ENG COMMANDED N1:${index}`, "percent", comN1);
+        //SimVar.SetSimVarValue(`TURB ENG THROTTLE COMMANDED N1:${index}`, "percent", comN1);
+        return;
+    }


Suggested change

setCommandedN1(index) {

//let alt = SimVar.GetSimVarValue("PRESSURE ALTITUDE", "feet");

let tat = SimVar.GetSimVarValue("TOTAL AIR TEMPERATURE", "kelvin");

let theta2 = tat / 288.15;

let tla = this.getTLA(index);

let idleN1 = this.getIdleN1(index);

let maxN1 = this.getMaxN1(index);

let comN1 = 0.01 * (maxN1 - idleN1) * tla + idleN1;

SimVar.SetSimVarValue(`L:SALTY_EEC_COM_N1:${index}`, "number", comN1);

//SimVar.SetSimVarValue(`TURB ENG COMMANDED N1:${index}`, "percent", comN1);

//SimVar.SetSimVarValue(`TURB ENG THROTTLE COMMANDED N1:${index}`, "percent", comN1);

return;

}

setCommandedN1(index) {

let tat = SimVar.GetSimVarValue("TOTAL AIR TEMPERATURE", "kelvin");

let theta2 = tat / 288.15;

let tla = this.getTLA(index);

let idleN1 = this.getIdleN1(index);

let maxN1 = this.getMaxN1(index);

let comN1 = 0.01 * (maxN1 - idleN1) * tla + idleN1;

SimVar.SetSimVarValue(`L:SALTY_EEC_COM_N1:${index}`, "number", comN1);

return;

}

helbertgs · 2023-01-11T12:50:09Z

salty-747/html_ui/Pages/Salty/SaltyFADEC.js

+    /*setN1(index) {
+        let tat = SimVar.GetSimVarValue("TOTAL AIR TEMPERATURE", "kelvin");
+        let theta2 = tat / 288.15;
+        let targetN1 = SimVar.GetSimVarValue(`L:SALTY_EEC_COM_N1:${index}`, "number"); //target N1 set by thrust lever position
+        let n1 = SimVar.GetSimVarValue(`TURB ENG N1:${index}`, "number") * 100; //actual N1 on the engine
+        SimVar.SetSimVarValue(`L:SALTY_EEC_N1:${index}`, "percent", n1); //for debugging
+        let tspool = 7.574 * (Math.log(targetN1) - Math.log(n1)); //time required in seconds
+        SimVar.SetSimVarValue(`L:SALTY_EEC_SPOOL_TIME:${index}`, "number", tspool); //for debugging
+        n1 *= Math.exp(0.001 * tspool * 0.132);
+        SimVar.SetSimVarValue(`L:SALTY_EEC_N1:${index}`, "percent", n1);
+        //SimVar.SetSimVarValue(`TURB ENG CORRECTED N1:${index}`, "percent", n1);
+        SimVar.SetSimVarValue(`TURB ENG N1:${index}`, "percent", n1);
+    }*/
+    /*setN2(index) {
+        let tat = SimVar.GetSimVarValue("TOTAL AIR TEMPERATURE", "kelvin");
+        let theta2 = tat / 288.15;
+        let tla = this.getTLA(index);
+        let maxN2 = (this.getMaxN1(index) + 117.5) / 2.025;
+        let idleN2 = (this.getIdleN1(index) + 117.5) / 2.025;
+        let n2 = 0.01 * (maxN2 - idleN2) * tla + idleN2;
+        SimVar.SetSimVarValue(`L:SALTY_COM_N2:${index}`, "percent", n2);
+        SimVar.SetSimVarValue(`TURB ENG CORRECTED N2:${index}`, "percent", (n2 / (theta2 ** 0.5)));
+        SimVar.SetSimVarValue(`TURB ENG N2:${index}`, "percent", n2);
+        return;
+    }*/
+    /*setN2 (index) {
+        let tat = SimVar.GetSimVarValue("TOTAL AIR TEMPERATURE", "kelvin");
+        let theta2 = tat / 288.15;
+        let targetN1 = SimVar.GetSimVarValue(`L:SALTY_EEC_COM_N1:${index}`, "number"); //target N1 set by thrust lever position
+        let targetN2 = (targetN1 + 117.5) / 2.025;
+        SimVar.SetSimVarValue(`L:SALTY_EEC_COM_N2:${index}`, "percent", targetN2);
+        //let n2 = SimVar.GetSimVarValue(`TURB ENG N2:${index}`, "number") * 100; //actual N2 on the engine
+        //SimVar.SetSimVarValue(`L:SALTY_EEC_N2:${index}`, "percent", n2); //for debugging
+        //let tspool = 26.636 * (Math.log(targetN2) - Math.log(n2)); //time required in seconds
+        //SimVar.SetSimVarValue(`L:SALTY_EEC_SPOOL_TIME:${index}`, "number", tspool); //for debugging
+        //n2 *= Math.exp(0.001 * tspool * 0.0375);
+        //SimVar.SetSimVarValue("L:SALTY_EEC_N1", "percent", n1);
+        //SimVar.SetSimVarValue("L:SALTY_EEC_N12", "percent", n12);
+        //SimVar.SetSimVarValue(`TURB ENG CORRECTED N2:${index}`, "percent", n2 / (theta2 ** 0.5));
+        //SimVar.SetSimVarValue(`TURB ENG N2:${index}`, "percent", n2);
+    }*/


What do you think about remove comments?

helbertgs · 2023-01-11T12:50:26Z

salty-747/html_ui/Pages/Salty/SaltyFADEC.js

+    setFuelFlow(index) {
+        let targetFF = SimVar.GetSimVarValue(`L:SALTY_EEC_COM_FF:${index}`, "number");
+        let FF = SimVar.GetSimVarValue(`TURB ENG FUEL FLOW:${index}`, "pound per hour");
+        let error = targetFF - FF;
+        /*while (error =! 0) {
+            //FF += 
+        }*/
+    }


Suggested change

setFuelFlow(index) {

let targetFF = SimVar.GetSimVarValue(`L:SALTY_EEC_COM_FF:${index}`, "number");

let FF = SimVar.GetSimVarValue(`TURB ENG FUEL FLOW:${index}`, "pound per hour");

let error = targetFF - FF;

/*while (error =! 0) {

//FF +=

}*/

}

setFuelFlow(index) {

let targetFF = SimVar.GetSimVarValue(`L:SALTY_EEC_COM_FF:${index}`, "number");

let FF = SimVar.GetSimVarValue(`TURB ENG FUEL FLOW:${index}`, "pound per hour");

let error = targetFF - FF;

}

helbertgs · 2023-01-11T12:50:45Z

salty-747/html_ui/Pages/Salty/SaltyFADEC.js

+    /*setFuelFlow(index) {
+        let p = SimVar.GetSimVarValue("AMBIENT PRESSURE", "hectopascal");
+        let p0 = 1013.25;
+        let oat = SimVar.GetSimVarValue("AMBIENT TEMPERATURE", "kelvin");
+        let tat = SimVar.GetSimVarValue("TOTAL AIR TEMPERATURE", "kelvin");
+        let t0 = 288.15;
+        let mach = SimVar.GetSimVarValue("AIRSPEED MACH", "mach");
+        let delta = p / p0;
+        let delta2 = delta * (1 + 0.2 * mach ** 2) ** 3.5;
+        let theta = oat / t0;
+        let theta2 = tat / t0;
+        let cff = SimVar.GetSimVarValue(`TURB ENG CORRECTED FF:${index}`, "pound per hour");
+        let ff = cff * delta2 * theta2 ** 0.5;
+        SimVar.SetSimVarValue(`TURB ENG FUEL FLOW:${index}`, "pound per hour", ff);
+        //SimVar.SetSimVarValue(`TURB ENG CORRECTED FF:${index}`, "pound per hour", ff);
+        return;
+    }*/


What do you think about remove this?

helbertgs · 2023-01-11T12:51:49Z

salty-747/html_ui/Pages/Salty/WT/Autopilot/SaltyNavModeSelector.js

+     //SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 23.2);
+     //SimVar.SetSimVarValue("K:AP_N1_HOLD", "bool", 1);


Suggested change

//SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 23.2);

//SimVar.SetSimVarValue("K:AP_N1_HOLD", "bool", 1);

helbertgs · 2023-01-11T12:51:59Z

salty-747/html_ui/Pages/Salty/WT/Autopilot/SaltyNavModeSelector.js

@@ -1664,7 +1664,7 @@
   activateThrustRefMode() {
     this.currentAutoThrottleStatus = AutoThrottleModeState.THRREF;
     Coherent.call("GENERAL_ENG_THROTTLE_MANAGED_MODE_SET", ThrottleMode.CLIMB);
-     SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 90);
+     //SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 90);


Suggested change

//SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 90);

helbertgs · 2023-01-11T12:52:08Z

salty-747/html_ui/Pages/Salty/WT/Autopilot/SaltyNavModeSelector.js

@@ -1618,7 +1618,7 @@
        return;
      }
      this.currentAutoThrottleStatus = AutoThrottleModeState.THR;
-      SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 80);
+      //SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 80);


Suggested change

//SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 80);

initial commit config files

7f4c1c8

747-4EVER changed the title ~~initial commit config files~~ New Flight Model Apr 17, 2022

Update Package Version

90ca8e3

747-4EVER marked this pull request as draft April 17, 2022 09:54

747-4EVER added 2 commits April 17, 2022 13:58

feat(FM): Initial Revised Brake Scalar

1d21889

fix(FM): Normalized Stab Trim Gauge

ccb01bd

boufogre and others added 21 commits April 18, 2022 17:47

initial fadec draft

0a60c47

changes

1da369b

flight model update

1723f03

fixed fuel tanks

ae4c9f4

refined drag

8a6753a

fmc takeoff page fix

7a0d236

CFD enabled

c321839

feat(Spoiler) Working flight detent limit

98d1f9f

Merge branch 'flight-model-new' of https://github.com/boufogre/salty-747

206fdfa

into pr/434

refined thrust vs mach

515c0a7

drag and thrust tuning

5f2e470

Merge branch 'flight-model-new' of https://github.com/boufogre/salty-747

8b222a6

into pr/434

fm tweaks

1b181b1

engines and fm tuning

a1529cb

fix(fuel flow): Initial commit fuel flow fix

1a334de

fix(Fuel) Switch to legacy Simvars to avoid fuel bug

698eddf

fix Tank index

83dd73a

fix(Fuel) All engines added

c7ae509

fix(fuel) sim rate fix

cab6f2c

feat(fuel) Fuel system transfers in JS

b3f9349

unlimited fuel fix

3c228e1

747-4EVER mentioned this pull request Jun 6, 2022

Flight model fixes #274

Closed

some changes

2085b73

some changes

abf7f48

helbertgs reviewed Jan 11, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Flight Model #434

New Flight Model #434

boufogre commented Apr 17, 2022 •

edited by 747-4EVER

Loading

DesertRick13 commented Apr 18, 2022

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

helbertgs Jan 11, 2023

		//SimVar.SetSimVarValue("K:AP_N1_REF_SET", "number", 23.2);
		//SimVar.SetSimVarValue("K:AP_N1_HOLD", "bool", 1);

New Flight Model #434

Are you sure you want to change the base?

New Flight Model #434

Conversation

boufogre commented Apr 17, 2022 • edited by 747-4EVER Loading

New Flight Model

DesertRick13 commented Apr 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boufogre commented Apr 17, 2022 •

edited by 747-4EVER

Loading