Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireflyIII Importer: Change domain name to fireflyiii-importer #401

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

PokePango
Copy link
Contributor

@PokePango PokePango commented Nov 25, 2024

Description

This pull request fixes an issue with client ID authentication between fireflyiii and fireflyiii_importer. Currently the importer only relies on Token Access, which requires to add a value to localhost.yml inventory. I personnaly haven't been able to successfully use the importer relying on the Token Access method.

Currently when creating a Client ID in Firefly III (Profile > Oauth) using an URL including a _ doesn't work and doesn't display any error message. Replacing it with - fixes this issue and allows you to use Client ID instead of an Access Token.

How Has This Been Tested?

  • Ran sb install sandbox-fireflyiii_importer and sandbox-fireflyiii
  • Created a Client ID referencing the correct domain name in Firefly III
  • Successfully imported data using Client ID instead of Token Access

For firefly users please don't forget to remove old containers since the name changed.

@owine
Copy link
Collaborator

owine commented Nov 25, 2024

Let’s remove the old container as a part of the role tasks. Example:

- name: Remove legacy Docker container
ansible.builtin.include_tasks: "{{ resources_tasks_path }}/docker/remove_docker_container.yml"
vars:
var_prefix: "qbit_manage"

@PokePango
Copy link
Contributor Author

Thanks for the heads up @owine!

@owine owine merged commit 86f76e3 into saltyorg:master Nov 25, 2024
185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants