FireflyIII Importer: Change domain name to fireflyiii-importer #401
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue with client ID authentication between fireflyiii and fireflyiii_importer. Currently the importer only relies on Token Access, which requires to add a value to localhost.yml inventory. I personnaly haven't been able to successfully use the importer relying on the Token Access method.
Currently when creating a Client ID in Firefly III (Profile > Oauth) using an URL including a
_
doesn't work and doesn't display any error message. Replacing it with-
fixes this issue and allows you to use Client ID instead of an Access Token.How Has This Been Tested?
sb install sandbox-fireflyiii_importer and sandbox-fireflyiii
For firefly users please don't forget to remove old containers since the name changed.