Fix test: tests/pytests/functional/states/file/test__check_directory_win.py #67163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an incorrect assertion in the temp_dir fixture. The owner of the the tmp_path is the Administrators group, it is never going to be the current user.
|
Those are now passing - https://github.com/saltstack/salt/actions/runs/12815637481/job/35736033652 @twangboy - if you could take a look and see if you're happy with this fix, that'd be great |
|
superseded by #67165. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes tests in tests/pytests/functional/states/file/test__check_directory_win.py
see #67140
Changes
temp_pathfixture to assert that directory is owned by theAdministratorsgroup, not the current userPrevious Behavior
Failing with
New Behavior
Now passing..