[3006.x] Remove wmic usage from disk grains on Windows #66968
Merged
+105
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
dmurphy18
previously approved these changes
Oct 14, 2024
twangboy
force-pushed
the
fix_66959_disks
branch
from
983891e to
22e80dc
Compare
dmurphy18
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
wmicbinary is being deprecated on Windows. Newer releases of Windows are starting to come with the binary disabled. This can be enabled, but we should probably migrate to something else.This PR will migrate the "disk" grain from using
wmicto using the PowerShell commandlet "Get-PhysicalDisk".What issues does this PR fix or reference?
Fixes #66959
Previous Behavior
A stack trace would occur and disk grains would be missing.
New Behavior
No stack trace, disk grains are present
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes