Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix for Nightly build Package test report failures #66924

Merged
merged 13 commits into from
Oct 3, 2024

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Sep 24, 2024

What does this PR do?

Resolves Windows Package Test failures in Test Reports on the Nightly Build.
Also seen occasional failures on Linux package test report too.

What issues does this PR fix or reference?

Fixes Windows Package Test failures in Test Reports on the Nightly Build

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 self-assigned this Sep 24, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner September 24, 2024 22:00
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Initial debug for Windows Package test failures [3006.x] Initial debug for Windows Package test failures Sep 24, 2024
@dmurphy18 dmurphy18 changed the title [3006.x] Initial debug for Windows Package test failures [3006.x] Fix for Nightly build Windows Package test failures Sep 24, 2024
@dmurphy18 dmurphy18 changed the title [3006.x] Fix for Nightly build Windows Package test failures [3006.x] Fix for Nightly build Package test report failures Sep 25, 2024
twangboy
twangboy previously approved these changes Sep 25, 2024
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only changes we really need, for now, are in tools/.

@dmurphy18
Copy link
Contributor Author

@dwoz Want to leave the other changes in there, since once we re-enable code coverage, we shall need them.

@dwoz
Copy link
Contributor

dwoz commented Oct 3, 2024

@dwoz Want to leave the other changes in there, since once we re-enable code coverage, we shall need them.

I'm skeptical that we need all those changes since we've been un-able to resolve the problem. Especially the sleeps.

@dwoz dwoz merged commit 1cf5424 into saltstack:3006.x Oct 3, 2024
832 checks passed
@dmurphy18 dmurphy18 deleted the fix_pkg_actions branch December 18, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants