-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Add proxy option to gitfs and git_pillar #66744
base: master
Are you sure you want to change the base?
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
@eisenmann-b1 Need to tick the |
I did not tick it since there are no new tests, which I felt would be necessary for this. |
@eisenmann-b1 you |
@dmurphy18 ok, I ticked the box. |
e784cae
to
266e8ac
Compare
Added the option to |
What does this PR do?
This PR add the options
gitfs_proxy
,git_pillar_proxy
andwinrepo_proxy
, with which a proxy server can be specified to be used for connecting to git repositories. These options can also be set per remote asproxy
, overriding the global options.For Pygit2, a warning will be given if
proxy
is set and the URL to the git repository does not have anhttps
scheme.This is due to an libgit2/libgit2#5650 in libgit2, the library pygit2 is using.
What issues does this PR fix or reference?
Fixes #30990
Previous Behavior
There is no option to specify the proxy server. The workaround described in #30990 requires changes to code akin to the ones here, or setting environment variables in service files.
New Behavior
A proxy server can now be specified like this:
In this example, the repository at
https://foo.com/bar.git
is fetched through the proxyhttp://proxy.com:8080/
.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes