[3007.x] Fix Salt-SSH loader attribute access, document that it's still not recommended #66606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
twangboy
approved these changes
Sep 18, 2024
Akm0d
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FunctionWrapperused in Salt-SSH templates behaves more like the regular LazyLoadersalt['foo.bar']()is to be preferred oversalt.foo.bar()since the latter can introduce edge casesWhat issues does this PR fix or reference?
Fixes: #41794
Fixes: #66376
Fixes: #66600
Previous Behavior
Several issues when using the
salt.foo.barsyntax (see linked issues)New Behavior
Works as expected. There might be some unknown edge cases though, so still prefer
salt['foo.bar'].Merge requirements satisfied?
Commits signed with GPG?
Yes