Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsxt_rest execution module and unit test #239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kdsalvy
Copy link
Contributor

@kdsalvy kdsalvy commented Mar 15, 2022

No description provided.

Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question What is the advantage of this module over, say the existing Salt http module? https://docs.saltproject.io/en/latest/ref/modules/all/salt.modules.http.html

@kdsalvy
Copy link
Contributor Author

kdsalvy commented Mar 23, 2022

Hi @waynew, this module was provided as a nsxt wrapper to the nsxt_rest utility which handles the errors and return nsxt specific error logs, for use cases where we don't have a module or state code prioritised in phase 1.

@waynew
Copy link
Contributor

waynew commented Mar 23, 2022

Could you provide a sample of what this does that the existing Salt http module doesn't do?

In other words: make a nsxt query using the http module, and make the same one using this code, to highlight the differences and advantages of using this vs the http module.

Looking at the code, including the call_api function, it is not at all immediately obvious that there are benefits to this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants