Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logout convenience function for destorying session #216

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jheiselman
Copy link
Contributor

This resolves issue #215

@nicholasmhughes
Copy link
Collaborator

Howdy! 👋

Apologies for the long delay on this integrating this code. We certainly appreciate your effort!

Pepper is getting some renewed focus and love, and we're checking in to see if you'd like to update this against the latest version of the base branch and ensure that all merge conditions are met.

If the items addressed by this contribution have already been fixed/added, are no longer an issue, or you no longer have a desire to work on this... please let us know and/or close out this PR.

If we don't hear from you within 7 days, we'll assume the code has been abandoned and close it out. If you'd like to revisit this in the future, you can always open a new PR.

Thank you, and we hope to see you active in the Salt ecosystem in the future!

@jheiselman
Copy link
Contributor Author

There is no base branch in your repository. My change is not also not behind the current commit on your develop branch.

@barneysowood
Copy link
Collaborator

@jheiselman - thanks looking at this again.

I've been working to get the test suite working again and moved to Github Actions, which is now complete.

Would you be able to update against the develop branch now?

Would you also be able to add some tests? Please let me know if you need any help with that.

I also note that although rest_cherrypy does support /logout, rest_tornado doesn't. If you have time, would you be able to update this to handle that? Again, please let me know if you need any help with that.

Thanks again for contributing this PR.

@jheiselman
Copy link
Contributor Author

I have merged the current develop branch into my repo.

You mentioned that rest_tornado does not support /logout. However, the pepper library has no way of knowing which backend is in-use. The best advice I could give is for someone to either try/catch the logout call or simply avoid the call if they know it is Saltnado servicing requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants