Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): config arrays as multiple lines #276

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

waynegemmell
Copy link
Contributor

@waynegemmell waynegemmell commented Jul 27, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#275

Describe the changes you're proposing

Details are in the issue attached but my change iterates through an array of parameters and writes the parameters on indivitual lines rather than dumping an array into the configuration file. The array dump is not parsable by mysql and it causes issues.

Pillar / config required to test the proposed changes

Example

mysql:
  server_config:
    file: 50-server.cnf
    # my.cnf sections changes
    sections:
      mysqld:
        replicate-ignore-table:
          - core.table1
          - core.table2                 
          - core.table3   

currently gets interpreted as

replicate-ignore-table = ['core.table1', 'core.table2', 'core.table3']
rather than the correct

replicate-ignore-table                  = 'core.table1'
replicate-ignore-table                  = 'core.table2'
replicate-ignore-table                  = 'core.table3'

This works on any array config value.

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@waynegemmell waynegemmell changed the title Configuration arrays are written out in independent lines fix(bug): config arrays as multiple lines Oct 4, 2023
@waynegemmell waynegemmell force-pushed the multi-values branch 2 times, most recently from 53961cf to c2363f9 Compare October 4, 2023 14:34
@jeff350
Copy link
Contributor

jeff350 commented Oct 12, 2023

@waynegemmell I just got the CI fixed for this formula, could you please rebase off of master for the CI tests to run.

@jeff350 jeff350 merged commit fbbe682 into saltstack-formulas:master Nov 28, 2023
4 checks passed
@saltstack-formulas-github

🎉 This PR is included in version 0.56.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants