Implement local prometheus #2
Conversation
Initial implementation of local deployment.
Add collectd exporter.
Support for statement in alerts.
Alerts for
prometheus/map.jinja
Outdated
| {%- set version = pillar.prometheus.get('version', '1.6.2') %} | ||
|
|
||
| {%- load_yaml as base_defaults %} | ||
| {%- if pillar.docker is defined and pillar.docker.host is defined %} |
There was a problem hiding this comment.
I'd use pillar.get('docker', {}).get('host')
There was a problem hiding this comment.
Yes, but this is still wrong, because you could have docker host without prometheus in them. I recommend using engine like gitlab:runner:engine = docker | local
or something like this
|
this PR looks very similar to https://github.com/richerve/prometheus-formula ? |
|
@michaelkuty can you please rebase? I will merge it then. |
|
|
||
| collectd_exporter_bin_link: | ||
| file.symlink: | ||
| - name: /usr/bin/collectd_exporter |
There was a problem hiding this comment.
You should use /usr/local/bin instead
| - name: prometheus | ||
| - shell: /bin/bash | ||
| - system: true | ||
| - home: /srv/prometheus |
There was a problem hiding this comment.
Use /var/lib/prometheus instead
| install: /opt | ||
| version_path: /opt/prometheus-{{ version }}.linux-amd64 | ||
| version: {{ version }}.linux-amd64 | ||
| source: https://github.com/prometheus/prometheus/releases/download/v{{ version }}/prometheus-{{ version }}.linux-amd64.tar.gz |
There was a problem hiding this comment.
I would prefer to use "standarized" metadata for selecting installation method:
source:
engine: tarball
url: https://...
hash: blahblah
defaulting for example to this to keep backward compatibility:
source:
engine: docker
in the similar manner as eg. for salt-formula-aptly, salt-formula-letsencrypt, etc.
|
I would like to upgrade to prometheus 2.0 instead reworking this PR |
|
I've updated https://github.com/richerve/prometheus-formula to prometheus 2.0, since the codebase is very similar it can be merged into this. |
|
really ? |
No description provided.