chore: streamline package publishing #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
requested changes
Sep 20, 2024
Splits the npm scripts into primary development tasks and lifecycle scripts: - `build` - `precommit`: Rebuilds all generated files - `prepack`: Lifecycle script to guarantee compiled files are up-to-date before publishing - `test` - `version`: Lifecycle script to guarantee all files affected by a version bump are regenerated and added to git All other scripts are prefixed with `_` to distinguish between the high-level development tasks above and smaller tasks that can be used as building blocks. Also included in this PR: - extracted the inline script that would check if any generated files had not been committed to `validate-generated-files.sh`
Splits the npm scripts into primary development tasks and lifecycle scripts: - `build` - `precommit`: Rebuilds all generated files - `prepack`: Lifecycle script to guarantee compiled files are up-to-date before publishing - `test` - `version`: Lifecycle script to guarantee all files affected by a version bump are regenerated and added to git All other scripts are prefixed with `_` to distinguish between the high-level development tasks above and smaller tasks that can be used as building blocks. Also included in this PR: - extracted the inline script that would check if any generated files had not been committed to `validate-generated-files.sh`
Splits the npm scripts into primary development tasks and lifecycle scripts: - `build` - `precommit`: Rebuilds all generated files - `prepack`: Lifecycle script to guarantee compiled files are up-to-date before publishing - `test` - `version`: Lifecycle script to guarantee all files affected by a version bump are regenerated and added to git All other scripts are prefixed with `_` to distinguish between the high-level development tasks above and smaller tasks that can be used as building blocks. Also included in this PR: - extracted the inline script that would check if any generated files had not been committed to `validate-generated-files.sh`
Suggested changes for CI and release automation
colincasey
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following today's v5 release, we saw a few points of improvement on our release process:
versionscript.a. The version file is also something we've considered removing, but in the meantime I've added a test to make sure that the file just exports a valid semver string.
The new release process is:
npm version <type>, using major/minor/etc. as appropriategit push && git push tags/<version>Important: Publishing will require creating/storing an
NPM_TOKENsecret. So gotta do that before this will actually work.This PR also contains a few prettier fixes because that happens sometimes.