chore(eslint): restore header rule #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes it less confusing to keep track
wjhsf
commented
Oct 8, 2024
| }, | ||
| ], | ||
|
|
||
| // Rules without config, sorted alphabetically by namespace, then rule |
There was a problem hiding this comment.
I didn't like how these rules were sorted before, so I fixed it.
| @@ -70,8 +89,47 @@ export default tseslint.config( | |||
| 'no-iterator': 'error', | |||
| 'no-lone-blocks': 'error', | |||
| 'no-proto': 'error', | |||
| 'no-new-require': 'error', | |||
There was a problem hiding this comment.
Astute observers may note that this rule has been removed because it's deprecated. It's a pattern we're unlikely to use in modern code, so it's not really worth switching to the replacement.
not worth booping 260 files
ekashida
approved these changes
Oct 8, 2024
nolanlawson
reviewed
Oct 14, 2024
| package: readJsonSync(join(path, 'package.json')), | ||
| })); | ||
| export const PRIVATE_PACKAGES = ALL_PACKAGES.filter((data) => data.package.private); | ||
| export const PUBLIC_PACKAGES = ALL_PACKAGES.filter((data) => !data.package.private); |
There was a problem hiding this comment.
Incidentally this file is missing a header. Maybe because it's .mjs?
There was a problem hiding this comment.
n/m – not published, so not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When doing the refactor in #4618, I noticed that the
header/headerrule was not being enforced. Turns out we removed it in #4378, because of Stuk/eslint-plugin-header#57. However, there's a simple workaround, so this PR restores the rule.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item