-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram slider component UI #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking pretty good, request a couple of changes.
Hey @benhinchley I've made the update. Can you take a look? |
@zlatanpham This is looking good, apologies for not attending to this sooner, I am currently battling with the documentation tool so I can get this running locally. Also I've just noticed there a couple of file conflicts, can you rebase this branch against current master and fix those. |
bcd2471
to
cb7b7e9
Compare
@benhinchley No problem! let me know if you want me take a look at the document problem too. |
Hey @benhinchley & @zlatanpham , I'm just looking at this issue that's been raised recently and it looks like some of the work in this PR could be used to solve the issue. Any ideas? |
Yeah @sampotts This can be used, I for the life of me cannot remember why I didn't merge this in the end. |
Addresses the UI part of #98. Examples of usage can be found by running
docs
.