Extract image-based PDFs #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Southclaws thanks for the PR. This lib was written a while back, error handling could definitely be much better! :) #19 got so close to getting this right, we should likely try to finish that off as it covers more image types and seems a bit closer to complete. Did you try that branch out at all? |
|
I didn't get a chance to try out 19 yet, I wrote this quickly before finding that PR! I'll give it a try later today and maybe help contribute to that solution :) |
|
Closing in favour of #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I quickly knocked this up then realised #19 already exists! But oh well, it's done now so it might be worth looking at...
It's not really solid code yet (error handling is literally just printf - but there doesn't seem to be a more elegant method available in the codebase either) but I thought I'd open a PR anyway to get some feedback :)