Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest upstream richardlehane/msoleps dependency instead of a fork #164

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

agcom
Copy link
Contributor

@agcom agcom commented Mar 3, 2024

The replace directive dependency (here) causes go install to fail:

go install code.sajari.com/docconv/v2/docd@latest
go: code.sajari.com/docconv/v2/docd@latest (in code.sajari.com/docconv/[email protected]):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

Further more, the referenced commit in the replace directive dependency does not belong to any branch (sajari/msoleps@d0092b82abea), probably because the branch was deleted after a successful PR.

As the temporary fork fix is merged into upstream (see here), revert to using the latest version of that.

@jonathaningram jonathaningram self-requested a review March 3, 2024 22:11
@jonathaningram jonathaningram merged commit 785a29a into sajari:master Mar 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants