[linux-glibc-devel] Update to 4.4 and convert to submodule. JB#58868 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
pvuorela
reviewed
Nov 20, 2024
rpm/0001-net-Update-API-for-VF-vlan-protocol-802.1ad-support.patch
Outdated
Show resolved
Hide resolved
rpm/0001-net-Update-API-for-VF-vlan-protocol-802.1ad-support.patch
Outdated
Show resolved
Hide resolved
rpm/0001-net-Update-API-for-VF-vlan-protocol-802.1ad-support.patch
Outdated
Show resolved
Hide resolved
rpm/0001-net-Update-API-for-VF-vlan-protocol-802.1ad-support.patch
Outdated
Show resolved
Hide resolved
rpm/0001-net-Update-API-for-VF-vlan-protocol-802.1ad-support.patch
Outdated
Show resolved
Hide resolved
Co-authored:by: Björn Bidar <[email protected]>
pvuorela
reviewed
Nov 22, 2024
|
|
||
| %build | ||
| make allyesconfig | ||
| make mrproper |
There was a problem hiding this comment.
This I'm not following. Why change? Make mrproper should be doing some cleaning, but there isn't anything really build? Older version actually did some config stuff.
There was a problem hiding this comment.
I made a test build with make allyesconfig for i486 -- the RPM packages are file-by-file identical (save the timestamped and commit-ref'd path for COPYING). I also checked OpenSUSE's .spec file, and it doesn't contain any make commands. I suspect that change is just a development leftover.
I'd say it can be left as-is (and that way we don't have to make yet another build round).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @Thaodan's branch update_submodule_patch.
Requires:
sailfishos/util-linux#12
sailfishos/libcap-ng#4