Add 3.13 support, remove 3.8 #202
Conversation
| @@ -55,7 +55,7 @@ jobs: | |||
| run: echo "CIBW_ARCHS=${{ matrix.cibw_archs }}" >> $GITHUB_ENV | |||
| shell: bash | |||
| - name: Build wheels | |||
| uses: pypa/cibuildwheel@v2.16.2 | |||
| uses: pypa/cibuildwheel@v2.21.2 | |||
There was a problem hiding this comment.
As of writing this version is both the latest, and the one that adds 3.13 support
https://github.com/pypa/cibuildwheel/releases
ChrisLovering
force-pushed
the
drop-3.8-add-3.13
branch
from
e98b46f to
0299ca1
Compare
|
actions/python-versions#312 has been merged, and 3.13 CI has passed here. Unsure why the macOS runners aren't picking up the outstanding jobs though. @saghul this is ready for review :) |
|
This is awesome, thank you! |
|
macOS CI failed as no runner picked up the jobs within a day, rather than due to an error in the change itself. That doesn't mean there isn't a problem with these changes, just that we don't know yet. |
|
macOS 11 was decomissioned, so we need to update pycares/.github/workflows/test.yml Line 12 in 57a82a0 |
This is the latest version of mac that runs on x86
|
Updated CI to run using macOS 13 (newest x86) and macOS 15 for M1 support. Various mac versions are failing the |
|
Can we get this merged and released? I'm really looking forward to Python 3.13 support :) Thank you! |
|
Tests are failing, any help with that would be welcome! |
|
Yeah, it looks like it's a potential flaky test, as it works on some Python versions on macOS 13 and then other Python versions on macOS 15. I don't have a mac so can't reproduce in order to fix it. |
|
It doesn't look like the failing tests are related to the Python 3.13 upgrade. |
|
I've been looking into the tests and my best guess is that it has to do with something with MacOS or how the tests are set up |
| @@ -9,8 +9,8 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-20.04, windows-2019, macos-11] | |||
| python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] | |||
| os: [ubuntu-20.04, windows-2019, macos-13, macos-15] | |||
There was a problem hiding this comment.
Something of note is that we should be testing against Windows 2022 and Ubuntu 24.04 if we are upgrading macos versions as well
|
Could you please upload CPython 3.13 wheels to PyPI? |
|
hey @saghul is there anything blocking making a release to pypi for this PR that we can help with? |
|
I tried to publish them but ran into a problem. Looks like a v3 / v4 upload action shenanigans. I'll try to look into it soon. |
CI will fail on 3.13 builds until actions/python-versions#312 is merged to add 3.13 support to setup-python