fix(cli): correct url ending with acryl.io:8080 (datahub-project#12289)

sagar-salvi-apptware · Jan 8, 2025 · a4c47fa · a4c47fa
1 parent 0fe4163
commit a4c47fa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/metadata-ingestion/src/datahub/cli/cli_utils.py b/metadata-ingestion/src/datahub/cli/cli_utils.py
@@ -330,6 +330,8 @@ def get_frontend_session_login_as(
 def _ensure_valid_gms_url_acryl_cloud(url: str) -> str:
     if "acryl.io" not in url:
         return url
+    if url.endswith(":8080"):
+        url = url.replace(":8080", "")
     if url.startswith("http://"):
         url = url.replace("http://", "https://")
     if url.endswith("acryl.io"):

diff --git a/metadata-ingestion/tests/unit/cli/test_cli_utils.py b/metadata-ingestion/tests/unit/cli/test_cli_utils.py
@@ -70,6 +70,10 @@ def test_fixup_gms_url():
         cli_utils.fixup_gms_url("http://abc.acryl.io/api/gms")
         == "https://abc.acryl.io/gms"
     )
+    assert (
+        cli_utils.fixup_gms_url("http://abcd.acryl.io:8080")
+        == "https://abcd.acryl.io/gms"
+    )
 
 
 def test_guess_frontend_url_from_gms_url():