Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update regex syntax in Wagmi README #582

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Jun 12, 2024

Fix a misleading regex example as pointed out by an external contributor.

katspaugh and others added 3 commits June 12, 2024 12:13
api-kit’s getSafeInfo endpoint returns way more information than our
communicator’s getInfo endpoint. This causes some dapps to use the
getInfo endpoint for just the readOnly flag (when running in an iframe)
and then to do api-kit getSafeInfo for the nonce and other props.
By returning nearly the same information from the getInfo endpoint we
make developers live easier.
Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: 7162dad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mmv08 mmv08 changed the base branch from main to development June 12, 2024 12:54
@mmv08 mmv08 merged commit f27a7d7 into development Jun 12, 2024
3 checks passed
@mmv08 mmv08 deleted the update-wagmi-readme branch June 12, 2024 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@dasanra dasanra restored the update-wagmi-readme branch June 12, 2024 13:53
@dasanra dasanra deleted the update-wagmi-readme branch June 12, 2024 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants