Reviewed and completed TODOs

safe-global · Apr 9, 2024 · 242261a · 242261a
1 parent 8ebb24c
commit 242261a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/app/src/main/java/io/gnosis/safe/ui/settings/owner/intro/OwnerInfoKeystoneFragment.kt b/app/src/main/java/io/gnosis/safe/ui/settings/owner/intro/OwnerInfoKeystoneFragment.kt
@@ -65,7 +65,6 @@ class OwnerInfoKeystoneFragment : BaseViewBindingFragment<FragmentOwnerInfoKeyst
 
             if (it.startsWith(UR_PREFIX_OF_HDKEY)) {
                 this.ur?.let { ur ->
-                    // TODO KST: parseExtendedPublicKey(ur) -> parseAccount(ur)
                     val hdKey = keystoneSDK.parseAccount(ur)
 
                     findNavController().navigate(
@@ -77,7 +76,6 @@ class OwnerInfoKeystoneFragment : BaseViewBindingFragment<FragmentOwnerInfoKeyst
                 }
             } else if (it.startsWith(UR_PREFIX_OF_ACCOUNT)) {
                 this.ur?.let { ur ->
-                    // TODO KST: parseMultiPublicKeys -> parseCryptoAccount (or parseMultiAccounts?)
                     val multiHDKeys = keystoneSDK.parseCryptoAccount(ur)
 
                     findNavController().navigate(

diff --git a/...rc/main/java/io/gnosis/safe/ui/settings/owner/keystone/KeystoneOwnerSelectionViewModel.kt b/...rc/main/java/io/gnosis/safe/ui/settings/owner/keystone/KeystoneOwnerSelectionViewModel.kt
@@ -86,11 +86,9 @@ class KeystoneOwnerSelectionViewModel
     fun getOwnerData(): Triple<String, String, String> {
         multiHDKeys?.let {
             val hdKey = it.keys[ownerIndex.toInt()]
-            // TODO KST: hdKey.sourceFingerprint -> hdKey.xfp
             return Triple(hdKey.toAddress().asEthereumAddressString(), derivationPath(ownerIndex), hdKey.xfp)
         } ?: run {
             val address = derivator.addressesForPage(ownerIndex, 1)[0]
-            // TODO KST: hdKey.sourceFingerprint -> hdKey.xfp
             return Triple(address.asEthereumAddressString(), derivationPath(ownerIndex), hdKey!!.xfp)
         }
     }

diff --git a/app/src/main/java/io/gnosis/safe/utils/PublicKeyDerivator.kt b/app/src/main/java/io/gnosis/safe/utils/PublicKeyDerivator.kt
@@ -48,7 +48,6 @@ class PublicKeyAndAddressDerivator: PublicKeyDerivator, PublicAddressDerivator {
 
     private fun derivedKeyForIndex(index: Long): ByteArray {
         val path = if (hdKey.note == Note.LEDGER_LEGACY.value) "m/$index" else "m/0/$index"
-        // TODO KST: hdKey.xpub? what should be parameter here? xfp? publicKey? must be a root hd node
         return sdk.derivePublicKey(hdKey.getExtendedPublicKey(), path).hexStringToByteArray()
     }
 }