This repository has been archived by the owner on Aug 12, 2019. It is now read-only.
We need to use sabre/dav's sql files because these are already out of sync #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is currently failing because one of the unittests contains an emoji, and we're not yet using utf8mb4 on sabre/dav. Opening a ticket in sabre/dav, and in the meantime changing the test in sabre/katana. |
|
I can't figure out what else to change to make the unittests not fail :( the error messages are rather cryptic and debugging is super hard. |
|
I figured it out. sabre/katana repurposes the digest authentication table for non-digest hashes. This will be a bit more work to fix, because it will require additional sql tables and a migration script. |
|
To fix, we'll create a new auth_basic table, and provide a simple migration script to move the faulty entries from the existing auth table. Post-0.4.0 release though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.