-
Notifications
You must be signed in to change notification settings - Fork 22
I dockerized your app #288
base: master
Are you sure you want to change the base?
Conversation
not well enough... |
yet more... evil commands....
yet more... evil commands....
@@ -8,7 +8,7 @@ install-server: | |||
composer install --no-dev | |||
|
|||
install-client: | |||
bower install --production | |||
bower install --production --allow-root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why --allow-root
?
Thanks for the PR! |
Actually I am changing it to use php7. Basically I was testing out hhvm because I had heard it was fast. I'll have another crack at it now. -Jake
|
Allow root because docker images build as root.
|
Neither PHP7 nor HHVM are currently fully supported unfortunately. For this to be accepted it should run on PHP 5.6. |
@evert sabre/dav does not support PHP7 yet? I thought yes since a recent release. |
I'll change it up. Sorry for the delays on my end. Thanks! -Jake Jacob Gadikian On Tue, Aug 18, 2015 at 12:37 PM, Ivan Enderlin [email protected]
|
Not even sure why I went for HHVM/PHP7 the first time around. Will submit again with 5.6 :). |
@Hywan , next major releases will support PHP 7. So vobject 4 and sabre/dav 3.1. |
Easier is better.
@evert: Oh yes, correct, remember the discussion now. Thanks. |
Would you have some brief instructions on how to test this on OS X? I don't have a lot of experience with docker. I'm pretty sure I have this container up and running, but I have no idea how to connect to port 80 of the container. |
Very needed tool, thanks for writing it!