minor changes, add release workflow

.github/workflows/release.yaml

@@ -0,0 +1,34 @@
+name: Release Strava for Obsidian plugin
+
+on:
+    push:
+        tags:
+            - '*'
+
+jobs:
+    build:
+        runs-on: ubuntu-latest
+
+        steps:
+            - uses: actions/checkout@v3
+
+            - name: Use Node.js
+              uses: actions/setup-node@v3
+              with:
+                  node-version: '18.x'
+
+            - name: Build plugin
+              run: |
+                  npm install
+                  npm run build
+
+            - name: Create release
+              env:
+                  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+              run: |
+                  tag="${GITHUB_REF#refs/tags/}"
+
+                  gh release create "$tag" \
+                    --title="$tag" \
+                    --draft \
+                    main.js manifest.json styles.css

main.ts

@@ -8,11 +8,7 @@ import {
 	addIcon,
 } from 'obsidian'
 import { AuthenticationConfig } from 'strava-v3'
-import {
-	fetchAthleteActivities,
-	fetchAthleteActivity,
-	fetchDetailedActivities,
-} from 'src/retriever'
+import { fetchAthleteActivities, fetchAthleteActivity } from 'src/retriever'
 import FileManager from 'src/fileManager'
 import { ee } from 'src/eventEmitter'
 import { DateTime } from 'luxon'
@@ -32,15 +28,13 @@ interface StravaActivitiesSettings {
 const DEFAULT_SETTINGS: StravaActivitiesSettings = {
 	authSettings: {
 		access_token: '',
-		client_id: '113274', // TODO: reset after input handler is implemented
-		client_secret: 'a596836c309eb7f08067aa7504907664998c896f', // TODO: reset after input handler is implemented
+		client_id: '',
+		client_secret: '',
 		redirect_uri: 'obsidian://obsidianforstrava/callback',
 	},
 	syncSettings: {
-		// lastSyncedAt: '2023-09-14T14:44:56.106Z', // setting to avoid excessive retrievals during dev
-		// activityDetailsRetrievedUntil: '2023-01-01T14:44:56.106Z', // setting to avoid excessive retrievals during dev
-		lastSyncedAt: '', // setting to avoid excessive retrievals during dev
-		activityDetailsRetrievedUntil: '', // setting to avoid excessive retrievals during dev
+		lastSyncedAt: '', // e.g., '2023-09-14T14:44:56.106Z'
+		activityDetailsRetrievedUntil: '', // e.g., '2023-01-01T14:44:56.106Z'
 	},
 }
 
@@ -126,7 +120,7 @@ export default class StravaActivities extends Plugin {
 								)
 								const activityId =
 									path.basename(activityDateFolder)
-								const activity = await fetchAthleteActivity(
+								await fetchAthleteActivity(
 									Number(activityId),
 									true,
 									file.path

manifest.json

@@ -1,9 +1,9 @@
 {
 	"id": "strava-obsidian",
-	"name": "Strava Activities",
+	"name": "Strava for Obsidian",
 	"version": "1.0.0",
 	"minAppVersion": "0.15.0",
-	"description": "Store your Strava activities in your Obsidian vault.",
+	"description": "Store and visualize Strava activities in your Obsidian vault.",
 	"author": "Saad Saif",
 	"authorUrl": "https://github.com/saadsaifse/strava-obsidian",
 	"fundingUrl": "https://www.buymeacoffee.com/saadsaif",

package.json

@@ -1,22 +1,20 @@
 {
-	"name": "obsidian-sample-plugin",
+	"name": "strava-for-obsidian",
 	"version": "1.0.0",
-	"description": "This is a sample plugin for Obsidian (https://obsidian.md)",
+	"description": "Store and visualize Strava activities in your Obsidian vault. (https://github.com/saadsaifse/strava-obsidian)",
 	"main": "main.js",
 	"scripts": {
 		"dev": "node esbuild.config.mjs",
 		"build": "tsc -noEmit -skipLibCheck && node esbuild.config.mjs production",
 		"version": "node version-bump.mjs && git add manifest.json versions.json"
 	},
-	"keywords": [],
-	"author": "",
+	"keywords": ["obsidian", "strava", "plugin"],
+	"author": "Saad Saif (https://github.com/saadsaifse)",
 	"license": "MIT",
 	"devDependencies": {
 		"@types/lodash": "^4.14.198",
 		"@types/luxon": "^3.3.2",
 		"@types/node": "^16.11.6",
-		"@types/passport": "^1.0.12",
-		"@types/request": "^2.48.8",
 		"@typescript-eslint/eslint-plugin": "5.29.0",
 		"@typescript-eslint/parser": "5.29.0",
 		"builtin-modules": "3.3.0",

src/auth.ts

@@ -54,12 +54,19 @@ class Auth {
 	}
 
 	async authenticate(authConfig: AuthenticationConfig) {
-		this.authConfig = authConfig
-		stravaApi.config(authConfig)
-		const url = await stravaApi.oauth.getRequestAccessURL({
-			scope: 'activity:read_all',
-		})
-		await open(url, undefined)
+		try {
+			this.authConfig = authConfig
+			stravaApi.config(authConfig)
+			const url = await stravaApi.oauth.getRequestAccessURL({
+				scope: 'activity:read_all',
+			})
+			await open(url, undefined)
+		} catch (error) {
+			console.log('Error while authenticating', error)
+			new Notice(
+				'Error authenticating. Please make sure to set Client ID and Client Secret in plugin settings first.'
+			)
+		}
 	}
 
 	async OAuthCallback(args: ObsidianProtocolData) {

src/mapUtils.ts

@@ -38,7 +38,7 @@ maxZoom: 18
 zoomDelta: 0.5
 geojsonFolder: .
 `
-	const leafletBlock = `~~~leaflet \n${leafletConfig} \n~~~`
+	const leafletBlock = `~~~leaflet \n${leafletConfig} ~~~`
 	return leafletBlock
 }
 

src/retriever.ts

@@ -21,7 +21,7 @@ export async function fetchAthleteActivities(
 		if (!auth.validateUtilization(stravaApi.rateLimiting)) {
 			return []
 		}
-		var args = {
+		const args = {
 			page: page,
 			per_page: pageSize,
 			after:

styles.css

@@ -1,12 +1,3 @@
-/*
-
-This CSS file will be included with your plugin, and
-available in the app when your plugin is enabled.
-
-If your plugin does not need CSS, delete this file.
-
-*/
-
 .svg-icon.stravaIcon {    
     fill: currentColor;
 }