Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x #100

Closed
wants to merge 24 commits into from
Closed

3.x #100

wants to merge 24 commits into from

Conversation

saade
Copy link
Owner

@saade saade commented Aug 9, 2023

v3 is out! This PR was closed due to the main branch deletion.

lam0819 and others added 6 commits August 7, 2023 13:49
- ditch dispatchBrowserEvent , livewire/livewire#5640
- v3 filament <x-filament::form> to <x-filament-panels::form>
- v3 filament plugin
@saade saade added the enhancement New feature or request label Aug 9, 2023
@saade saade self-assigned this Aug 9, 2023
@chengkangzai
Copy link
Contributor

i dont want to sound pushing ...
but do we have a timeline for this package to support filament v3 ?
or any blockage of this PR that communities can help?

Thanks for your work!

@saade
Copy link
Owner Author

saade commented Sep 20, 2023

hey @chengkangzai,

currently the plugin already works in v3, the latest version that supports v3 is v3.0.0-beta3

i do have some refactor (and breaking changes) to do before i can tag v3, i don't want to tag v3 right now and break someone's app later with the BCs

@chengkangzai
Copy link
Contributor

Alright, I will test it out and let you know if it have any problems 🤘

Thanks again @saade 🙏

@Sh1d0w
Copy link

Sh1d0w commented Sep 20, 2023

hey @chengkangzai,

currently the plugin already works in v3, the latest version that supports v3 is v3.0.0-beta3

i do have some refactor (and breaking changes) to do before i can tag v3, i don't want to tag v3 right now and break someone's app later with the BCs

Thanks, but it does not seem to work

 Problem 1
    - Root composer.json requires saade/filament-fullcalendar 3.0.0-beta3 -> satisfiable by saade/filament-fullcalendar[v3.0.0-beta3].
    - saade/filament-fullcalendar v3.0.0-beta3 requires filament/filament ^2.0 -> found filament/filament[v2.5.3, ..., v2.17.53] but it conflicts with your root composer.json require (^3.0).

@saade
Copy link
Owner Author

saade commented Sep 20, 2023

Thanks, but it does not seem to work

 Problem 1
    - Root composer.json requires saade/filament-fullcalendar 3.0.0-beta3 -> satisfiable by saade/filament-fullcalendar[v3.0.0-beta3].
    - saade/filament-fullcalendar v3.0.0-beta3 requires filament/filament ^2.0 -> found filament/filament[v2.5.3, ..., v2.17.53] but it conflicts with your root composer.json require (^3.0).

Weird, i'm requiring ^3.0

@Sh1d0w
Copy link

Sh1d0w commented Sep 21, 2023

@saade According to GitHub releases the 3.0.0-beta3 tag is published to composer from this commit https://github.com/saade/filament-fullcalendar/tree/7f4a801ee40eec4db2004ed913c4e8dcfc68b54f

Which is the main branch. The 3 tag should be published from the 3.x branch instead. I will install the package directly from GitHub branch, but just to let you know in future that the current tag is still pointing to the main branch where it has filament 2 support.

@saade
Copy link
Owner Author

saade commented Sep 21, 2023

@saade According to GitHub releases the 3.0.0-beta3 tag is published to composer from this commit https://github.com/saade/filament-fullcalendar/tree/7f4a801ee40eec4db2004ed913c4e8dcfc68b54f

Which is the main branch. The 3 tag should be published from the 3.x branch instead. I will install the package directly from GitHub branch, but just to let you know in future that the current tag is still pointing to the main branch where it has filament 2 support.

🤦🏼 i've target the wrong branch, sorry about that v3.0.0-beta4 is out

@chengkangzai
Copy link
Contributor

Aite the full plugin work perfectly in my upgrade to filament v3 👍

Good job! Thanks Saade once again

@chengkangzai
Copy link
Contributor

I apologies, just realise there is error in browser's console log. Attached with the console log.
But the plugin still shows tho

Screenshot 2023-09-24 at 11 23 20 AM Screenshot 2023-09-24 at 11 23 28 AM Screenshot 2023-09-24 at 11 26 49 AM

@saade
Copy link
Owner Author

saade commented Sep 26, 2023

👀 only documentation left

@saade saade deleted the branch main September 26, 2023 21:59
@saade saade closed this Sep 26, 2023
@saade
Copy link
Owner Author

saade commented Sep 26, 2023

V3 is out! this PR was closed due to main branch deletion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants