Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update INTT QA by adding templete plot #77

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryota4495
Copy link

Update cluster size of INTT QA.
I add the reference plot run by run which was made from expected value of each size by gauss fitting.
You can compare between the reference plot and current plot run by run.

Copy link
Contributor

@osbornjd osbornjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't merge this as you are loading in files from a local directory which will not work in a production environment. How are you testing this? You should be using the macro under the macros subdir (i.e. subsystems/intt/macros) and feeding the histogram file through the arguments. Did you add the production of these histograms to the relevant QA module (presumably somewhere in here)?

@osbornjd osbornjd marked this pull request as draft September 10, 2024 11:58
@ryota4495
Copy link
Author

ryota4495 commented Sep 11, 2024

I tested in local directory connecting to test website using
export QA_HTMLDIR=/sphenix/WWW/subsystem/QAHtmlTest/
I didn't add the production. So should I upload template root file into CDB?

@osbornjd
Copy link
Contributor

How did you produce this root file? What are its contents?

@ryota4495
Copy link
Author

ryota4495 commented Sep 11, 2024

I made this root file using data driven method. So, I use multiple cluster size distribution root file generated by OfflineQA module. We don't need to produce the file run by run or store by store.
I just realized that the code is reading template root file from my local directory. I will put the full path of my root file, I hope it would be work. Please let me know if you have any concern, or suggestions.
Do you have any recommended directory in SDCC?

@osbornjd
Copy link
Contributor

I think there is confusion about how this should work - the root file with the histograms created by the offline QA module should be read in via the steering macro, not via some c code in the drawing module itself. For example, you should use this macro to read in the root file with the histograms and then the module will actually draw those histograms
https://github.com/sPHENIX-Collaboration/QAhtml/blob/main/subsystems/intt/macros/draw_intt.C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants