Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Tooltips working again #827

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

HQJaTu
Copy link
Contributor

@HQJaTu HQJaTu commented Mar 13, 2024

Admin-page tooltips were not doing anything when clicked.

Fix was to add a missing space between two accessibility HTML-attributes. Having HTML in working order enabled the functionality again.

@garvinhicking
Copy link
Member

Oooh. That is embarassing. 😅

Would you like to ammend your commit with an entry to docs/NEWS? That's our "living" changelog, you could attribute your fix there and make my merge process a bit easier.

Thanks!!

@HQJaTu
Copy link
Contributor Author

HQJaTu commented Mar 14, 2024

Again, hopefully my update is in the correct spot. Generally speaking, I have no idea on how release management works in this project.

@garvinhicking garvinhicking merged commit 975461d into s9y:master Mar 15, 2024
@garvinhicking
Copy link
Member

Thanks!

Release management basically is:

  • Whenever we make a commit, we also edit docs/NEWS and add a changelog entry there (unless it's a very basic change that doesn't need an entry).
  • So for Pull requests, ideally if people want to write a changelog entry for that too, they could include it in their commit and we merge it directly. Then we maintainers don't need a distinc extra commit for it

Once we feel that there are important issues fixed or new features added, we create a new release and increase version numbers. Some info on that is here: https://github.com/s9y/Serendipity/wiki/Creating-a-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants