Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: endpoints re-rejig #70

Merged
merged 8 commits into from
Nov 20, 2024
Merged

chore: endpoints re-rejig #70

merged 8 commits into from
Nov 20, 2024

Conversation

shikhar
Copy link
Member

@shikhar shikhar commented Nov 20, 2024

No description provided.

@shikhar shikhar force-pushed the hostend branch 6 times, most recently from fc41f55 to 77a31bb Compare November 20, 2024 17:49
@shikhar
Copy link
Member Author

shikhar commented Nov 20, 2024

putting up for API review

@shikhar shikhar marked this pull request as ready for review November 20, 2024 17:50
@shikhar shikhar requested a review from a team as a code owner November 20, 2024 17:50
src/service.rs Outdated Show resolved Hide resolved
Copy link
Member

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the comment about IS_BASIN_REQUEST.

@shikhar shikhar merged commit 00bbdd2 into main Nov 20, 2024
3 checks passed
@shikhar shikhar deleted the hostend branch November 20, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants