Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exercise limits for read session #27

Merged
merged 7 commits into from
Nov 20, 2024
Merged

feat: exercise limits for read session #27

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d1f2c49
..
infiniteregrets Nov 19, 2024
623cac5
feat: exercise limits for read session
infiniteregrets Nov 20, 2024
b3b88a9
.
infiniteregrets Nov 20, 2024
2fed1da
cr
infiniteregrets Nov 20, 2024
e7c9b5c
.
infiniteregrets Nov 20, 2024
2f6d05f
..
infiniteregrets Nov 20, 2024
1d1aff6
explicit
infiniteregrets Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ enum StreamActions {
/// If a limit is not specified, the reader will keep tailing and wait for new records.
Read {
/// Starting sequence number (inclusive). If not specified, the latest record.
#[arg(short, long)]
infiniteregrets marked this conversation as resolved.
Show resolved Hide resolved
start: u64,
infiniteregrets marked this conversation as resolved.
Show resolved Hide resolved
infiniteregrets marked this conversation as resolved.
Show resolved Hide resolved

/// Output records to a file or stdout.
Expand All @@ -224,9 +225,11 @@ enum StreamActions {
output: Option<RecordsOut>,
infiniteregrets marked this conversation as resolved.
Show resolved Hide resolved

/// Limit the number of records returned.
#[arg(long)]
Copy link
Member

@shikhar shikhar Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have -n for this as well?

limit_count: Option<u64>,

/// Limit the number of bytes returned
/// Limit the number of bytes returned.
#[arg(long)]
infiniteregrets marked this conversation as resolved.
Show resolved Hide resolved
limit_bytes: Option<ByteSize>,
},
}
Expand Down