Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow S2_CELL to be set #20

Closed
wants to merge 3 commits into from
Closed

feat: allow S2_CELL to be set #20

wants to merge 3 commits into from

Conversation

infiniteregrets
Copy link
Member

No description provided.

@infiniteregrets infiniteregrets requested a review from a team as a code owner November 7, 2024 03:52
@shikhar
Copy link
Member

shikhar commented Nov 7, 2024

let's wait on this as discussing what env vars SDK's from_env() should recognize

@shikhar
Copy link
Member

shikhar commented Nov 15, 2024

these can be added (mostly convenience for us, except for S2_CELL in future) https://github.com/s2-streamstore/s2-sdk-rust/blob/b9637acef6c8698bbe90fc3e2ef0fda09ee9b1f9/src/client.rs#L203-L206

@shikhar
Copy link
Member

shikhar commented Nov 21, 2024

New env vars are S2_CLOUD / S2_ACCOUNT_ENDPOINT / S2_BASIN_ENDPOINT - but I don't think makes sense to sticky them in CLI config!

@shikhar shikhar closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhar shikhar Awaiting requested review from shikhar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infiniteregrets @shikhar