Switch get_face_single() to order from largest to smaller #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacksider
approved these changes
Jul 19, 2023
|
When this will be merged ? |
|
Wouldn't it cause confusion when there are faces that are comparable in size? Like in a group photo? |
|
It's better sometimes, worse sometimes IMO. Maybe it can be a setting, as in which sorting "algorithm" to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to my PR at roop s0md3v/roop#731
Many times I wished the order was closer to what I expected. I tried to find concrete docs on the faces'
bboxbut couldn't. I did find this example which seems good enoughThe current implementation is picking whichever is more to the left. I think a better default (given one HAS to be chosen) is grabbing the largest one. That's usually the one closer to the viewer and the main point of focus.