[wpilib] Update values on controllable sendables (wpilibsuite#4667)

rzblue · Nov 19, 2022 · cf8faa9 · cf8faa9
1 parent 5ec067c
commit cf8faa9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/wpilibc/src/main/native/cpp/smartdashboard/SendableBuilderImpl.cpp b/wpilibc/src/main/native/cpp/smartdashboard/SendableBuilderImpl.cpp
@@ -26,7 +26,8 @@ void SendableBuilderImpl::PropertyImpl<Topic>::Update(bool controllable,
                                                       int64_t time) {
   if (controllable && sub && updateLocal) {
     updateLocal(sub);
-  } else if (pub && updateNetwork) {
+  }
+  if (pub && updateNetwork) {
     updateNetwork(pub, time);
   }
 }

diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SendableBuilderImpl.java
@@ -82,7 +82,8 @@ public void close() {
     void update(boolean controllable, long time) {
       if (controllable && m_sub != null && m_updateLocal != null) {
         m_updateLocal.accept(m_sub);
-      } else if (m_pub != null && m_updateNetwork != null) {
+      }
+      if (m_pub != null && m_updateNetwork != null) {
         m_updateNetwork.accept(m_pub, time);
       }
     }