[wpilib] DataLogManager: Warn user if logging to RoboRIO 1 internal s…

…torage (wpilibsuite#5617)
rzblue · Sep 11, 2023 · 339ef1e · 339ef1e
1 parent 7a9a901
commit 339ef1e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/wpilibc/src/main/native/cpp/DataLogManager.cpp b/wpilibc/src/main/native/cpp/DataLogManager.cpp
@@ -21,6 +21,7 @@
 
 #include "frc/DriverStation.h"
 #include "frc/Filesystem.h"
+#include "frc/RobotBase.h"
 
 using namespace frc;
 
@@ -69,6 +70,11 @@ static std::string MakeLogDir(std::string_view dir) {
       (s.permissions() & fs::perms::others_write) != fs::perms::none) {
     return std::string{usbDir};
   }
+  if (frc::RobotBase::GetRuntimeType() == kRoboRIO) {
+    FRC_ReportError(warn::Warning,
+                    "DataLogManager: Logging to RoboRIO 1 internal storage is "
+                    "not recommended! Plug in a FAT32 formatted flash drive!");
+  }
 #endif
   return frc::filesystem::GetOperatingDirectory();
 }

diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DataLogManager.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DataLogManager.java
@@ -204,8 +204,13 @@ private static String makeLogDir(String dir) {
       } catch (IOException ex) {
         // ignored
       }
+      if (RobotBase.getRuntimeType() == RuntimeType.kRoboRIO) {
+        DriverStation.reportWarning(
+            "DataLogManager: Logging to RoboRIO 1 internal storage is not recommended!"
+                + " Plug in a FAT32 formatted flash drive!",
+            false);
+      }
     }
-
     return Filesystem.getOperatingDirectory().getAbsolutePath();
   }