Fix optimized clear all path

ryansolid · May 17, 2019 · 3c7a832 · 3c7a832
1 parent 7cd605f
commit 3c7a832
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "mobx-jsx",
   "description": "Raw MobX performance without the restraints of a Virtual DOM",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "author": "Ryan Carniato",
   "license": "MIT",
   "repository": {
@@ -18,7 +18,7 @@
   "devDependencies": {
     "@babel/core": "7.4.3",
     "@babel/preset-typescript": "7.3.3",
-    "dom-expressions": "0.8.2",
+    "dom-expressions": "0.8.4",
     "hyper-dom-expressions": "~0.8.0",
     "lit-dom-expressions": "~0.8.0",
     "mobx": "^5.9.0",

diff --git a/src/runtime.js b/src/runtime.js
@@ -168,7 +168,7 @@ function eventHandler(e) {
       handler(e, model);
       if (e.cancelBubble) return;
     }
-    node = node.host || node.parentNode;
+    node = (node.host && node.host instanceof Node) ? node.host : node.parentNode;
   }
 }
 
@@ -366,8 +366,8 @@ export function each(parent, accessor, expr, options, afterNode) {
 
       // Fast path for clear
       if (length === 0 || isFallback) {
-        if (beforeNode !== undefined || afterNode !== undefined) {
-          let node = beforeNode != undefined ? beforeNode.nextSibling : parent.firstChild;
+        if (beforeNode || afterNode) {
+          let node = beforeNode ? beforeNode.nextSibling : parent.firstChild;
           removeNodes(parent, node, afterNode === undefined ? null : afterNode);
         } else parent.textContent = "";
         disposeAll();