inline in template boolean literals #385
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change, inlines in the template boolean literals. For example
<el attr={true}/>
becomes<el attr/>
and
<el attr={false}/>
becomes<el/>
Considerations:
The most recent issue illustrating this props vs attr problem comes from #384 In there they are doing
<video playsinline={true} />;
, in production code currently:_el$.playsInline = true;
_$setProperty(_el$, "playsinline", true);
With this change,
true
case and skipped for thefalse
case"true" | boolean
, so trying to do `"false"`` as a string should be a type errorI am hoping before solid 2.0 we can get rid of the hardcoded list of properties
Thanks!