Merge pull request #389 from edemaine/tagged-template-literals

Treat tagged templates as function calls
ryansolid · Dec 10, 2024 · 828f9e9 · 828f9e9
2 parents a1d24a1 + 6a23046
commit 828f9e9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/packages/babel-plugin-jsx-dom-expressions/src/shared/utils.js b/packages/babel-plugin-jsx-dom-expressions/src/shared/utils.js
@@ -94,7 +94,7 @@ export function isDynamic(path, { checkMember, checkTags, checkCallExpressions =
     return false;
   }
 
-  if (checkCallExpressions && (t.isCallExpression(expr) || t.isOptionalCallExpression(expr))) {
+  if (checkCallExpressions && (t.isCallExpression(expr) || t.isOptionalCallExpression(expr) || t.isTaggedTemplateExpression(expr))) {
     return true;
   }
 

diff --git a/packages/babel-plugin-jsx-dom-expressions/test/__dynamic_fixtures__/fragments/code.js b/packages/babel-plugin-jsx-dom-expressions/test/__dynamic_fixtures__/fragments/code.js
@@ -27,6 +27,9 @@ const singleExpression = <>{inserted}</>;
 
 const singleDynamic = <>{inserted()}</>;
 
+const greeting = (x) => "Hello " + x;
+const singleTemplateLiteral = <>{greeting`world`}</>
+
 const firstStatic = (
   <>
     {inserted}

diff --git a/packages/babel-plugin-jsx-dom-expressions/test/__dynamic_fixtures__/fragments/output.js b/packages/babel-plugin-jsx-dom-expressions/test/__dynamic_fixtures__/fragments/output.js
@@ -27,6 +27,8 @@ const multiDynamic = [
 ];
 const singleExpression = inserted;
 const singleDynamic = _$memo(inserted);
+const greeting = x => "Hello " + x;
+const singleTemplateLiteral = _$memo(() => greeting`world`);
 const firstStatic = [inserted, _tmpl$3()];
 const firstDynamic = [_$memo(inserted), _tmpl$3()];
 const firstComponent = [_$createComponent(Component, {}), _tmpl$3()];