Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added refresh token mechanism #1247

Open
wants to merge 5 commits into
base: minor
Choose a base branch
from
Open

Conversation

MrGhostXUz
Copy link

In our music player app, a client need to have Authorization headers. When I gave ConcatenatingAudioSource, the player was stuck after some time, when the given token is expired. So I decided to add inbuilt mechanism to refresh credentials by adding some optional fields. I am sure that I didn't break any existing features.

@ryanheise
Copy link
Owner

This solution seems specific to the proxy (i.e. won't work with useProxyForRequestHeaders = false). In that case, have you considered doing this outside the plugin with a custom stream audio source?

@MrGhostXUz
Copy link
Author

MrGhostXUz commented May 27, 2024

This solution seems specific to the proxy (i.e. won't work with useProxyForRequestHeaders = false). In that case, have you considered doing this outside the plugin with a custom stream audio source?

Yes, the solution is specific for ConcatenatingAudioSource in other word for something like playlists. I think, if someone needs this auth mechanism with useProxyForRequestHeaders = false, providing concrete cases, then I will expand my solution. Until then, I think it is time-wasting.

@ryanheise
Copy link
Owner

I want to avoid highly specific solutions, so I am not going to be in a rush to make design decisions such as this one. For the library itself, there is a preference to more general APIs that provide the flexibility to do various things. Is StreamAudioSource enough to allow an implementation within the app? If not, let me know so that we can design another abstraction that would be powerful enough to allow the app to build such things on top of it.

chaimPaneth added a commit to chaimPaneth/just_audio that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants