-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add relbar (breadcrumbs) #102
base: master
Are you sure you want to change the base?
Conversation
{%- for parent in parents %} | ||
<li><a href="{{ parent.link|e }}" {% if loop.last %}{{ accesskey("U") }}{% endif %}>{{ parent.title }}</a></li> | ||
{%- endfor %} | ||
<li class="active">{{ title }}</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation looks off here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've fixed it.
Can you post screenshots of this in the demo? |
@shiumachi -- Thanks for the additional work. I'm actually out of the country, so won't get a chance to try this out until a week from now. So if I'm out of touch until then it's because of that and I'll pick things up after. Thanks again! |
np, no need to hurry. |
@shiumachi -- Can you split this into two options or a different type of configuration to allow top and / or bottom relbars to be shown? @russell -- Any thoughts on this one? |
@ryan-roemer it does seem more naturall to have a relbar at the top only. I don't think it really matters if it's one opiton or two. Probably one option would be more clear to the user. |
Hi @ryan-roemer and @russell, IMO current option would be enough.
This is the same way which is mentioned in Sphinx official document. But if you guys think it's better to have two option for relbars, I can put it in my patch. a) split into two options |
Hi @shiumachi -- I like the idea of not having to override the base template to disable this new functionality. Let's go for:
/cc @russell |
Is this implemented? |
@piernik you're looking at the exact current state of implementation right here. If you would like to open a new PR that is
that would be awesome! |
sorry but I don't know anything about shipx and/or python and/or github :/ |
This patch introduces relbar macro (breadcrumbs).
The macro is turned off by default.
If user want to turn on this feature, set 'relbar_enable' to 'true'.