Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relbar (breadcrumbs) #102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shiumachi
Copy link
Contributor

This patch introduces relbar macro (breadcrumbs).
The macro is turned off by default.
If user want to turn on this feature, set 'relbar_enable' to 'true'.

{%- for parent in parents %}
<li><a href="{{ parent.link|e }}" {% if loop.last %}{{ accesskey("U") }}{% endif %}>{{ parent.title }}</a></li>
{%- endfor %}
<li class="active">{{ title }}</li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks off here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've fixed it.

@ryan-roemer
Copy link
Owner

Can you post screenshots of this in the demo?

@shiumachi
Copy link
Contributor Author

Here is the screenshot:

relbar_example

If you want to include this into repository, please let me know where is the best place to put the image.

I've found that a new page is needed to show this feature.
I'll add the page into the PR.

@ryan-roemer
Copy link
Owner

@shiumachi -- Thanks for the additional work. I'm actually out of the country, so won't get a chance to try this out until a week from now. So if I'm out of touch until then it's because of that and I'll pick things up after. Thanks again!

@shiumachi
Copy link
Contributor Author

np, no need to hurry.
Enjoy your trip!

@ryan-roemer
Copy link
Owner

@shiumachi -- Can you split this into two options or a different type of configuration to allow top and / or bottom relbars to be shown?

@russell -- Any thoughts on this one?

@russell
Copy link
Collaborator

russell commented Jun 19, 2014

@ryan-roemer it does seem more naturall to have a relbar at the top only. I don't think it really matters if it's one opiton or two. Probably one option would be more clear to the user.

@shiumachi
Copy link
Contributor Author

Hi @ryan-roemer and @russell,

IMO current option would be enough.
User can override relbar1 or relbar2 in layout.html to remove top or bottom relbar:

{% block relbar2 %}{% endblock %}

This is the same way which is mentioned in Sphinx official document.
http://sphinx-doc.org/templating.html

But if you guys think it's better to have two option for relbars, I can put it in my patch.
There is two way:

a) split into two options relbar1_enable and relbar2_enable
b) add new option relbar_position which can be set to top, bottom, or both (default).

@ryan-roemer
Copy link
Owner

Hi @shiumachi -- I like the idea of not having to override the base template to disable this new functionality. Let's go for:

  • add new option relbar_position which can be set to top, bottom, both, none. And make none the default.

/cc @russell

@piernik
Copy link

piernik commented Oct 20, 2016

Is this implemented?

@ryan-roemer
Copy link
Owner

@piernik you're looking at the exact current state of implementation right here. If you would like to open a new PR that is

that would be awesome!

@piernik
Copy link

piernik commented Oct 20, 2016

sorry but I don't know anything about shipx and/or python and/or github :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants