Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite recursion, misleading warning "SSH command timeout" #158

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix infinite recursion, misleading warning "SSH command timeout" #158

merged 1 commit into from
Nov 28, 2023

Conversation

albertz
Copy link
Member

@albertz albertz commented Nov 27, 2023

No description provided.

michelwi
michelwi reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@michelwi michelwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On comment inline, otherwise lgtm

sisyphus/son_of_grid_engine.py Show resolved Hide resolved
@albertz albertz merged commit d241ef4 into master Nov 28, 2023
3 checks passed
@albertz albertz deleted the albert-fix-wrong-warn-msg-ssh-timeout branch November 28, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelwi michelwi michelwi approved these changes

@critias critias Awaiting requested review from critias

@Atticus1806 Atticus1806 Awaiting requested review from Atticus1806

@dthulke dthulke Awaiting requested review from dthulke

@mmz33 mmz33 Awaiting requested review from mmz33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertz @michelwi